Re: [PATCH] dir: do all size checks before seeking back and fix file closing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote Sat, Aug 26, 2006:
> Jonas Fonseca wrote:
> >   err:
> > -	if (0 <= fd)
> > +	if (0 >= fd)
> >  		close(fd);
> 
> Could you explain that piece?  You now only close "fd" if it's zero (stdin)
> or negative (invalid).  The old code (close if its >=0) make more sense.

Ah, yes, sorry for the noise. I read the old code as (fd <= 0).

-- 
Jonas Fonseca
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]