Re: [PATCH/RFC 1/x] gitweb: Use git-diff-tree patch output for commitdiff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> Junio C Hamano wrote:
>
>> Jakub Narebski <jnareb@xxxxxxxxx> writes:
>> 
>>> Converting "blobdiff" and "blobdiff_plain" format would be much easier
>>> if git-diff-tree and friends had -L <label>/--label=<label> option,
>>> like GNU diff has.
>> 
>> I am not sure how that would be useful, given that you would
>> disect the header line-by-line to colorize anyway.
>
> gitweb could output patch directly (slurp-print) in blobdiff_plain,
> if there were -L <label>/--label=<label> option to git-diff. As it is now
> git_blobdiff_plain (or git_blobdiff('plain')) would have to process diff
> header, replacing hashes by file names.

I do not think gitweb does diff between two arbitrary blobs; in
other words, you only need "diff-tree treeA treeB -- path".

I think feeding object names _is_ what's causing you trouble.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]