Jakub Narebski <jnareb@xxxxxxxxx> writes:
> This patch tries (but no too hard) to fit gitweb source in 80 columns,
> for 2 columns wide tabs, and indent and align source for better
> readibility.
If you are doing the wrapping, which I think is a good idea, I
do not think you should target for an oddball setting. Where
did you get the idea of 2-column tabs?
> While at it added comment to 'snapshot' entry defaults for %feature
> hash, corrected "blobl" action in git_blame2 and git_blame to "blob",
> key of argument to $cgi->a from 'class' to '-class'.
All look good otherwise; applied.
> +our %feature = (
> + # feature => {'sub' => feature-sub, 'override' => allow-override, 'default' => [ default options...]
> + # if feature is overridable, feature-sub will be called with default options;
> + # return value indicates if to enable specified feature
I'd prefer if you wrapped these to match the real ones.
> + 'snapshot' => {
> + 'sub' => \&feature_snapshot,
> + 'override' => 0,
> + # => [content-encoding, suffix, program]
> + 'default' => ['x-gzip', 'gz', 'gzip']},
> );
Because making this 3-tuple into a hashref would be an overkill,
it is a very good idea to comment it here.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html