Junio C Hamano wrote:
> So the last part of the above should perhaps read:
>
> my @result = ();
> for (my $i = 0; $i < @mapping; $i += 2) {
> my ($name, $symbol) = ($mapping[$i], $mapping[$i+1]);
> if (defined $params{$name}) {
> push @result, join('=', esc_param($symbol),
> esc_param($params{$name}));
> }
> }
There is really no need to escape $symbol; we control this,
and it is CGI param safe.
BTW. why use join? The following
push @result, "$symbol=" . esc_param($params{$name});
would be simplier... we could even use
$href .= ($i > 0? ";" : "") . "$symbol=" . esc_param($params{$name});
although probably this isn't best idea (worse readibility).
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html