On 8/16/06, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> > > > Remove unnecessary iteration variable in inline.
> > > > - for (i = 0; i < in; i++) putchar(' ');
> > > > + for (; in > 0; in--)
> > >
> > > while(in--) putchar(' ');
> > >
> >
> > That goes into an infinite loop if the argument is negative because
> > it emits a cmpl $0, x(%ebp). Should never happen, but there's no
> > reason not to prevent it with a for loop.
>
> while (in-- > 0) putchar(' ');
>
> still shorter :)
>
It emits a slightly rearranged assembly with the same number of instructions.
oops. I should've looked at the output. But the point moot anyway, Junio says :)
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html