Re: [PATCH] gitweb: Show project's git URL on summary page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/15/06, David Rientjes <rientjes@xxxxxxxxxx> wrote:
On Tue, 15 Aug 2006, Jakub Narebski wrote:

> +     my $is_first_url = 1;
> +     foreach my $git_base_url (@git_base_url_list) {
> +             next unless $git_base_url; # skip empty/zerolength URLs
> +             print "<tr><td>";
> +             if ($is_first_url) {
> +                     print "URL";
> +                     $is_first_url = 0;
> +             }
> +             print "</td><td>$git_base_url/$project</td></tr>\n";
> +     }

Isn't it faster to do this (over 1.4.2):
+       my $url_tag = "URL";
+       foreach my $git_base_url (@git_base_url_list) {
+               next unless $git_base_url;
+               print "<tr><td>$url_tag</td><td>$git_base_url/$project</td></tr>\n";
+               $url_tag = "";
+       }

Yes, it is undobtedly better.

Acked-by: Jakub Narebski <jnareb@xxxxxxxxx>

--
Jakub Narebski
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]