Junio C Hamano wrote: > Jakub Narebski <jnareb@xxxxxxxxx> writes: > >> + if ($status eq "A") { # created >>... >> + } elsif ($status eq "D") { # deleted >>... >> + } elsif ($status eq "M" || $status eq "T") { # modified, or type changed >>... >> + } elsif ($status eq "R") { # renamed >>... >> + } elsif ($status eq "C") { # copied >>... >> + } # we should not encounter Unmerged (U) or Unknown (X) status > > The body of these still seem to have quite a lot of > similarities. Maybe further refactoring is in the works? Probably. For now I only separated the difftree printing part into separate subroutine, and added $status eq "C" case (I don't know if we might encounter it at all, due to current set of options to diff-tree). -- Jakub Narebski Warsaw, Poland ShadeHawk on #git - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html