Re: [PATCH 28/28] makes upload_pack void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/15/06, David Rientjes <rientjes@xxxxxxxxxx> wrote:
On Tue, 15 Aug 2006, Nikolai Weibull wrote:
> I don't know for sure, but I'm guessing the intention was to be able
> to return a failing code /if/ there ever was a condition where
> upload_pack() would fail, e.g., if send_ref() would return a status
> code instead of die():ing if it can't parse the given sha1.  In a
> future libification, the change of return type may have to be
> reverted.

Of course.

If upload_pack were modified to return an error code based on a specific code
path, I trust the implementer would know how to change void to int.

So do I.  However, I trust that whoever implemented send_ref() knew
about void.  (See how easy it was to do what you did but the other way
around?)

It was just a comment.  I don't have anything against the patch as such.

 nikolai
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]