Quoting r. Junio C Hamano <junkio@xxxxxxx>: > > This looks familiar; did the build error out when compiling > > convert-objects.c by any chance? I suspect you have the same problem > > that I encountered. My fix was posted in "[PATCH 6/10] Fix header breakage > > with _XOPEN_SOURCE." > > > > I have included my earlier mail message inline below, in case you wish > > to confirm the that it fixes things for you too. > > Alternatively Ramsay's _XOPEN_SOURCE patch is part of "next", so > if it fixes the problem for you that would confirm the patch is > a good one to have. > BTW, would it make sense fr this patch to be cherry-picked into 1.4.8? I guess the reason that LNK macros are under GNU_SOURCE is the following text from stat(2): The S_ISLNK and S_ISSOCK macros are not in POSIX.1-1996, but both will be in the next POSIX standard; the former is from SVID 4v2, the latter from SUSv2. -- MST - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html