Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> Besides, I really use it often -- you should try it! Call me blind, but
> very often I cannot spot the differences (in the unified diff) when they
> are minor, especially when there was just a typo in the documentation. You
> could now say that I should not care about it, then, but if _I_ made the
> mistake, I want to learn from it.
I tried it on this:
diff --git a/builtin-apply.c b/builtin-apply.c
index c159873..be2c715 100644
--- a/builtin-apply.c
+++ b/builtin-apply.c
@@ -1700,10 +1700,8 @@ static int apply_data(struct patch *patc
return -1;
/* NUL terminate the result */
- if (desc.alloc <= desc.size) {
+ if (desc.alloc <= desc.size)
desc.buffer = xrealloc(desc.buffer, desc.size + 1);
- desc.alloc++;
- }
desc.buffer[desc.size] = 0;
patch->result = desc.buffer;
which shows something like:
diff --git a/builtin-apply.c b/builtin-apply.c
index c159873..be2c715 100644
--- a/builtin-apply.c
+++ b/builtin-apply.c
@@ -1700,10 +1700,8 @@ static int apply_data(struct patch *patc
return -1;
/* NUL terminate the result */
if (desc.alloc <= desc.size)
{
desc.buffer = xrealloc(desc.buffer, desc.size + 1);
desc.alloc++;
}
desc.buffer[desc.size] = 0;
patch->result = desc.buffer;
where "desc.alloc++;" and next lines and the opening brace after
if() are red. Why does that red opening brace have to come at
the beginning of line, I wonder...
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html