Junio C Hamano wrote: > (3) NEEDS_LIBICONV is found to be unnecessary by configure, but > the link fails like this without it: > > builtin-mailinfo.o: In function `convert_to_utf8': > /git/builtin-mailinfo.c:539: undefined reference to `_libiconv_open' > /git/builtin-mailinfo.c:560: undefined reference to `_libiconv' > /git/builtin-mailinfo.c:561: undefined reference to `_libiconv_close' > collect2: ld returned 1 exit status Does the following patch help? +++ autoconf: Set NEEDS_LIBICONV unconditionally if there is no iconv in libc Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx> --- configure.ac | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 5926f3c..61c9fa3 100644 --- a/configure.ac +++ b/configure.ac @@ -172,8 +172,7 @@ AC_CHECK_LIB([expat], [XML_ParserCreate] # # Define NEEDS_LIBICONV if linking with libc is not enough (Darwin). AC_CHECK_LIB([c], [iconv],[], -[AC_CHECK_LIB([iconv],[iconv], - [GIT_CONF_APPEND_LINE(NEEDS_LIBICONV=YesPlease)],[])]) +[GIT_CONF_APPEND_LINE(NEEDS_LIBICONV=YesPlease)]) # # Define NEEDS_SOCKET if linking with libc is not enough (SunOS, # Patrick Mauritz). -- 1.4.1.1 - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html