Re: [PATCH 9/10] Remove cmd_usage() routine and re-organize the help/usage code.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Ramsay Jones" <ramsay@xxxxxxxxxxxxxxxxxxx> writes:

> In any event, I'm sorry to have broken your test,

Don't worry.  My primary function while wearing the "maintainer"
hat is to catch mistakes like this; even if this test breakage
slipped through, it would not have been your fault but mine.

> ... I should have
> documented the changed behaviour. The change should be limited to
> a lower-case usage prefix and a change in exit code from 1 to 129.

I think both are good changes.  The native usage() exits with 129
so it would be consistent for the git wrapper to exit with 129
when it gives usage message, and in lowercase.

Will take a look at your patches when I go home (I am at day-job
today).

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]