Junio C Hamano <junkio@xxxxxxx> wrote:
> I understand that (1) "@@FOO@@" is problematic, (2) being able
> to run gitweb/gitweb.perl while coming up with improvements is
> nice, but (3) not being able to say "/etc/foo/$ENV{SITE_NAME}"
> is quite a drawback on the deployment side.
>
> So why don't we use something other than @@, perhaps "++FOO++"?
That's the other way to solve this. If there is no typical character
for filenames which is handled different in double quotes this is fine
for me too.
> I'm inclined to take these two patches:
>
> gitweb: optionally read config from GITWEB_CONFIG (Jeff King)
> gitweb: require $ENV{'GITWEB_CONFIG'} (Matthias Lederhofer)
The suggestion by Jeff King to use
our $GITWEB_CONFIG = $ENV{GITWEB_CONFIG} || '@@GITWEB_CONFIG@@';
sounds reasonable too.
> so on top of them something like this?
[patch replacing @@ with ++]
Ack.
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html