Re: [PATCH] gitweb: optionally read config from GITWEB_CONFIG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthias Lederhofer wrote:

> Jakub Narebski <jnareb@xxxxxxxxx> wrote:
>> Jeff King wrote:
>> > @@ -56,7 +50,7 @@ # URI of GIT logo
>> >  our $logo = "@@GITWEB_LOGO@@";
>> >  
>> >  # source of projects list
>> > -our $projects_list = "@@GITWEB_LIST@@" || "$projectroot";
>> > +our $projects_list = "@@GITWEB_LIST@@";
>> >  
>> >  # default blob_plain mimetype and default charset for text/plain blob
>> >  our $default_blob_plain_mimetype = 'text/plain';
>> 
>> But why that change?
> Earlier this was undef if the user did not change it.  Now this is
> always a string so the second one will probably never come into play
> except the user chooses to set the string to undef again.

Empty string is also false in Perl. Try

  perl -e 'my $var = "" || "other"; print "var = $var\n";'

I'd rather use $projectroot for $projects_list, preferably without needing
to set $projects_list.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git


-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]