On Sun, 2006-07-30 at 22:57, Luben Tuikov wrote: > --- Martin Waitz <tali@xxxxxxxxxxxxxx> wrote: > > Generate gitweb/gitweb.cgi to reduce the need to patch gitweb.cgi by > > the end user. > > The GIT installation directory and version are already known by the > > Makefile, they can be inserted directly into gitweb. > > All other gitweb configuration parameters can now be specified > > by providing GITWEB_* variables while building GIT. > > These are described in gitweb/README. > > NACK. > > I don't like it. While this method works, it is too much effort > to have to run make to do this, plus it pollutes your tree. > > Instead, what you can do is make gitweb.cgi read a text file > from . which has those variables defined. > > This way, I can just copy gitweb.cgi into my web-server directory > and voila it works, since the variable definition file would > always be there. This way: > - no need to run make to build "gitweb.cgi" or "gitweb.pl" whatever > you call it, > - no need to pollute your tree with site defined variables, > - simple copy (cp) would install a working version, instead of > the current cp + patch with local settings method. > > Luben Which sounds frighteningly similar to a patch I submitted quite a while ago, and brought up again twice, and have had stomped on once. So what now? :-) jdl - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html