On Monday 31 July 2006 20:45, Jakub Narebski wrote: > Josef Weidendorfer wrote: > > > On Monday 31 July 2006 16:03, you wrote: > >> I'm going to rename some gitweb subroutines to better correspond to what > >> given subroutine does. I have problem: how to name main "action" > >> subroutines? Currently they use git_ prefix, e.g. git_logo. > >> git_project_list, git_rss, git_summary, git_heads,... > > > > print_* or write_* ? > > At least, the functions print/write the HTML code to stdout of the script. > > The problem is that there are subroutines which print _fragments_ of HTML > code (like git_header_html or git_print_page_path) which would use probably > print_ prefix. Action subroutines output always whole page. Why not "print_*_page", if they print out a whole page? I would "git_header_html" rename to "print_header"; it's clear that it prints out HTML ;-) And "git_print_page_path" only needs stripping of "git_" prefix. Josef - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html