Junio C Hamano writes: > Matthias Lederhofer <matled@xxxxxxx> writes: > > > Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > >> Why? The three users of cmd_log_walk() need to call setup_pager() > >> explicitely, when cmd_log_walk() can do it for them? > > > > The explanation is below the commit message: > > "setup_pager has to be called before git_diff_ui_config because the > > latter uses pager_use_color initialized by setup_pager." > > If that is the reason, perhaps we could restructure the setting > and use of of diff_use_color_default like the attached, which > would be cleaner. AFAICS Matthias' patch has the added benefit of moving setup_pager to before large files (i.e. packs) are mapped. This helps non-COW-fork (i.e. cygwin) tremendously. Actually with Linus' setup refactoring this could probably be easily moved to the wrapper, but I'm too stupid so I just deleted setup_pager from my version:-) jr - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html