Hi, On Fri, 28 Jul 2006, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Signed-off-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx> > > A quick comment without looking much at the code. Do you sanely > bail out when asked to reverse-apply a binary patch? Nope. I swap old_sha1_prefix and new_sha1_prefix in that case, I hoped that is enough? > Also what was the reason to change an existing test vector in > 4102? That does not look like related to -R flag. I changed "copy" to "rename", so that I could reuse that patch to test -R, too. Note that in the end, the original test vector is written, and tested. Ciao, Dscho - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html