Re: [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
> ---
>  git-instaweb.sh |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 242b55e..340ab98 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -245,4 +245,5 @@ esac
>  
>  start_httpd
>  test -z "$browser" && browser=echo
> +which "$browser" >/dev/null 2>&1 || browser=echo
>  $browser http://127.0.0.1:$port

>From what I hear, 'which' isn't portable on some platforms.

Now this isn't the only place 'which' is used in instaweb, and I've been
meaning to get rid of the other 'which' call in there for a while, but I
haven't had much time to devote to git the past few weeks.  Help here
would be good.

-- 
Eric Wong
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]