Re: [PATCH 3/5] git-instaweb: store parameters in config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 26 Jul 2006, Johannes Schindelin wrote:

> On Wed, 26 Jul 2006, Junio C Hamano wrote:
> 
> > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> > 
> > > It already reads the config for defaults, and now it also stores
> > > the last passed parameters in the config.
> > 
> > This might need to be conditional -- usually people override the
> > default from the command line as a one-shot thing, and storing
> > them in the configuration file would upset them.
> 
> I agree that this should be conditional, but the other way round, no? 

Being bitten by my own words. It is plain dumb to store parameters for 
which instaweb fails. And my patch did that. Oh, well.

So, I'd say: just forget about patches [3-5]/5.

Ciao,
Dscho

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]