On Sun, Jul 23, 2006 at 01:24:22PM +0200, Jan-Benedict Glaw wrote: > If people only were used to *always* place a comma behind the last > array element, the diff would be shorter by one line each time... I agree that it's much more convenient; I left it off because it wasn't there before and I thought there were some standardization issues. As it turns out, the situation is quite ridiculous. C89 allowed trailing commas in initialization lists but not in enums. Most compilers (gcc, sun) accepted it anyway, but some (aix xlc) did not. Do we care? I think probably not, since the color_diff enum already had a trailing comma. It seems like the primary non-gcc compiler that has been mentioned is sun cc. I don't know what other compilers are being used to compile git. -Peff - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html