On Tue, 18 Jul 2006, Yakov Lerner wrote: > > How about making this parameter (do-use-mmap vs not-use-mmap) > a *runtime* parameter ? The thing is, there are really two different kinds of users, and one of them in particular (the pack-file case) shouldn't have the problems under Windows at all (because the pack-files aren't moved), and have a much bigger reason to use mmap in the first place (because accesses will be sparse, so reading the whole file is wasteful). The other user was the index file, and _that_ one is the one that gets renamed (to replace the previous index file), and that one is also not ever read only partially, so using "read()" instead of mmap is much less of an issue. So I really think we should just basically always mmap the pack-files (it should work everywhere), and make NO_MMAP just trigger on the other cases. Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html