On Thu, 2006-07-13 at 18:05 -0700, Linus Torvalds wrote: > > On Thu, 13 Jul 2006, Junio C Hamano wrote: > > > > I am not sure what function incparent() is trying to do with > > this: > > > > git rev-list --max-count=1 --topo-order $1 -- . > > Yeah, that looks strange. > > The "--topo-order" in particular looks pointless, and just slows things > down. > > The default ordering from git-rev-list (and all other revision listing > things, ie "git log" etc) _does_ guarantee that we never show a child > before _one_ of its parents has been shown (although "parent" in this case > may be the command line). Does it? I thought at one point it sorted on some random criterion like alphabetically by author, or some other cosmetic information which isn't really part of the git structure -- like the timestamp or something? We still don't enforce monotonicity, do we? The timestamps are still just fluff? > But that thing is doubly strange, because it uses "." as a path specifier. > If this is done in the top-most directory, that should mean "all changes", > which in turn means that the whole thing should be equivalent to > > git rev-parse "$1^0" > > since all commits should make _some_ change, and thus the first revision > in the list should always be the top commit - the one you passed in as an > argument. In this case, I really do have commits in the intermediate tree which don't actually change anything, and I want to filter them out -- I couldn't see a simple way to do it all in one pass. -- dwmw2 - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html