moreau francis wrote: > 2 RETs is missing. One after the Subject line and the other before the > Signed-off-by line. If I add the first missing RET, all works fine. I guess > it's missing because of git-cherry-pick command. But I don't understand > why the last RET is missing > > Can anybody tell me why ? > Maybe that patch does what you want. -- >8 -- Subject: [PATCH] Add a newline before appending "Signed-off-by:" It looks nicer. Signed-off-by: Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> --- log-tree.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/log-tree.c b/log-tree.c index ebb49f2..2551a3f 100644 --- a/log-tree.c +++ b/log-tree.c @@ -19,7 +19,7 @@ static int append_signoff(char *buf, int char *cp = buf; /* Do we have enough space to add it? */ - if (buf_sz - at <= strlen(signed_off_by) + signoff_len + 2) + if (buf_sz - at <= strlen(signed_off_by) + signoff_len + 3) return at; /* First see if we already have the sign-off by the signer */ @@ -34,6 +34,7 @@ static int append_signoff(char *buf, int return at; /* we already have him */ } + buf[at++] = '\n'; strcpy(buf + at, signed_off_by); at += strlen(signed_off_by); strcpy(buf + at, signoff); -- 1.4.1.g35c6-dirty - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html