Re: What's in git.git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 7 Jul 2006, Junio C Hamano wrote:

>  - Early parts of Perly Git by Petr Baudis with help from others
>    are merged to "next".  Please report breakages before other
>    Perl scripts are converted to use this.

I saw many problems on my machines with this, just as I expected. Please 
play it _really_ safe. I hated to be forced to rewrite git-fmt-merge-msg 
in C, but I just could not use 'next' without that. I would hate it even 
more to rewrite git-mv in C just to make the tests happy (they are not on 
my iBook right now).

>  - GIT_TRACE by Matthias Lederhofer.  What it lets you do is
>    interesting (although I personally do not foresee myself
>    using it), and I am in favor of its inclusion.  The issue
>    that the mechanism does not let you trace some commands
>    (scripts) raised on the list has stalled this topic branch.
>    I'd either want people to agree that it is not a problem, or
>    if they feel it is a problem, have a fix for that, before
>    merging this to "next".

You probably allude to my comments, which were meant more as a hint to go 
towards C, instead of scripts. There is a lot to be said about C, but the 
fact is: if you have most of the core of git in C (if not all of it), you 
have less problems (especially when integrating over _all_ platforms and 
setups).

As it is, I am all for inclusion of GIT_TRACE support. If need be, 
everybody can add GIT_TRACE support to the script she is debugging. And if 
she's nice, she can send a patch to the list, too.

>  - Auto configuration by Pasky and Jakub.  This deserves a fresh
>    paragraph.

I can see why some may want autoconf (or a clone of MPlayer's configure) 
in git. But the fact is: on many platforms, the Makefile works out of the 
box. Especially on cygwin, where _any_ shell script -- and autoconf 
generated scripts in particular -- are slower than a dog's poo, it is 
_soooo_ much better to be able to just say "make".

Please, please, _please_ keep autoconfiguration _strictly_ opt-in.

>    Linus Torvalds:
>       builtin "git prune"

FWIW, I read the code, too, and I agree it is ready for 'next'. After my 
first read, I was curious why the parameter "object_array *p" was needed 
for all the process_* functions. It turned out that add_object() needs 
this. Just in case anybody else wonders.

Ciao,
Dscho

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]