On Wed, 5 Jul 2006, Johannes Schindelin wrote:
> Hi,
>
> On Tue, 4 Jul 2006, Linus Torvalds wrote:
>
> > static void process_tag(struct tag *tag, struct object_array *p, const char *name)
> > {
> > struct object *obj = &tag->object;
> > struct name_path me;
>
> AFAICS this variable is set, but not used:
>
> >
> > if (obj->flags & SEEN)
> > return;
> > obj->flags |= SEEN;
> >
> > me.up = NULL;
> > me.elem = "tag:/";
> > me.elem_len = 5;
> >
> > if (parse_tag(tag) < 0)
> > die("bad tag object %s", sha1_to_hex(obj->sha1));
> > add_object(tag->tagged, p, NULL, name);
Yeah, that NULL should be "&me".
That said, we don't actually use the object name logic at all, so we could
drop it entirely. Having it _might_ allow some of the error messages to be
better, who knows..
Linus
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html