On Mon, 3 Jul 2006, Linus Torvalds wrote: > > Oh, and for all the same reasons, we should use > > int zlib_compression_level = Z_BEST_COMPRESSION; That should be Z_DEFAULT_COMPRESSION, of course. Anyway, I think the patches are ok as-is, and my suggestion to avoid the "-1" and use Z_DEFAULT_COMPRESSION is really just an additional comment, not anything fundamental. So Junio, feel free to add an Acked-by: Linus Torvalds <torvalds@xxxxxxxx> regardless of whether also doing that. Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html