Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > > > free(NULL) is safe. > > > > > > Is it? I vaguely remember that I had problems with this on some obscure > > > platform. > > > > I don't think so. > > Well, after a little Googling, I am more convinced than ever that it is a > BAD thing to rely on free(NULL) being a NOP. I did some research too. Seems that C89 requires free(NULL) to be a no-op but on some old systems (SunOS) it may crash. IMNSHO these systems were designed to crash valid programs and torture developers. There are probably many free(NULL) and realloc(NULL, ...) uses in the git source code and are not worth fixing. -- http://onion.dynserv.net/~timo/ - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html