Junio C Hamano wrote:
> git grep -e VISUAL -e EDITOR revealed this inconsistency. All
> other commands seem to check VISUAL and then EDITOR as they should.
>
> + my $editor = $ENV{VISUAL} || $ENV{EDITOR} || 'vi';
> system($editor, $compose_filename);
Shouldn't we check if we are in visual (non CLI-only) environment,
like X-Window, MS Windows or MacOS X, before trying to use VISUAL?
How other parts solve it? </me checks> Ah, we use VISUAL unconditionally,
at least in scripts...
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html