Junio C Hamano <junkio@xxxxxxx> writes:
> Marco Roeland <marco.roeland@xxxxxxxxx> writes:
>
>> In commit 6294a10 it was noted that "on x86-64 it seems that Git.xs does
>> not link without compiling the main git objects with -fPIC". Set it
>> therefore automatically on this platform.
>
> I agree with it in principle but was too lazy to do that myself.
> I wonder it should be inside Linux, though.
>
>> ifeq ($(uname_S),Linux)
>> NO_STRLCPY = YesPlease
>> + ifneq (,$(findstring x86_64,$(uname_M)))
>> + USE_PIC = YesPlease
>> + endif
>> endif
In other words, I am wondering why you did not do this more
obvious one:
ifeq ($(uname_M),x86_64)
USE_PIC = YesPlease
endif
My suspicion is that you protected that in Linux on purpose
because you know that my version would break for somebody else,
or because you are trying to be cautious not to break other
platforms you do not have access to, and I cannot tell which.
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html