On 6/28/06, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
> > > > - use a pipe to "git-update-index --index-info" instead of using command > > > > line > > ...and to take it a step further, a patch (0002) to avoid too many calls to > git-write-tree and to git-update-index. ... and introduces a lot more lines doing debug output.
well, that's how I found out about what to fix. Was really impressed when saw the difference :) What stands out next is getRenames (to be renamed into get_renames), a little profiling shows that the renames lists are the culprit this time too. I actually expected these problems, but decided to postpone the optimization for later: linked lists are comfortable to work with. I didn't had much time for this project, and the first commit is dated 7th June - it was a very slow progress.
However, the change is good, but I would not call it "FILE *fp". IMHO "FILE *update_index_pipe" would explain better what you do there.
just update_index would be enough. It can't possibly mean anything else, being FILE* in that context. By the way, is it safe to use "git-update-index --index-info"? AFAICS it was designed for this kind of use, but the most visible user of it (git-update-recursive.py) didn't use --index-info this way! Was there any specific reasons? - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html