Signed-off-by: Jeff King <peff@xxxxxxxx> --- This allows compiling with gcc -Wall -Werror, which makes finding useful warnings easier. I also think the 'if' is easier to read than the short-circuit. quote.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/quote.c b/quote.c index dcc2326..1910d00 100644 --- a/quote.c +++ b/quote.c @@ -13,7 +13,7 @@ #include "quote.h" * a!b ==> a'\!'b ==> 'a'\!'b' */ #undef EMIT -#define EMIT(x) ( (++len < n) && (*bp++ = (x)) ) +#define EMIT(x) do { if (++len < n) *bp++ = (x); } while(0) static inline int need_bs_quote(char c) { -- 1.4.1.rc1.g29f4a-dirty - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html