Re: [PATCH] whatchanged: Default to DIFF_FORMAT_RAW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Timo Hirvonen <tihirvon@xxxxxxxxx> writes:

> Signed-off-by: Timo Hirvonen <tihirvon@xxxxxxxxx>
> ---
>  builtin-log.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/builtin-log.c b/builtin-log.c
> index 5b3fadc..8a39770 100644
> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -28,6 +28,15 @@ static int cmd_log_wc(int argc, const ch
>  			rev->always_show_header = 0;
>  	}
>  
> +	if (!rev->diffopt.output_format && !rev->simplify_history) {
> +		/* Ugly hack!
> +		 *
> +		 * rev->simplify_history == 0 -> whatchanged
> +		 * Can't do this before setup_revisions()
> +		 */

Indeed it is ugly.  Might it be a cleaner option to signal _wc
function what command its caller is, by adding an extra
parameter (or check argv -- ugh)?

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]