Timo Hirvonen <tihirvon@xxxxxxxxx> writes: > Add msg_sep variable to struct diff_options. msg_sep is printed after > commit message. Default is "\n", format-patch sets it to "---\n". > > This also removes the second argument from show_log() because all > callers derived it from the first argument: > > show_log(rev, rev->loginfo, ... Good catch. Thanks. > Signed-off-by: Timo Hirvonen <tihirvon@xxxxxxxxx> > --- I often wonder if the separator should be "\n---\n" instead when I see something like the above, but do not change it yet please. > I'm not 100% sure if format-patch is the only one wanting "---\n". git log --patch-with-stat should also show "---\n". > But I think "\n" should be used for every command that doesn't create > patches. This sounds good. We probably would want to have an output format testsuite to catch regression. - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html