On Sun, Jun 25, 2006 at 03:54:34AM +0200, Petr Baudis wrote:
> -sub open_pipe {
> - if ($^O eq '##INSERT_ACTIVESTATE_STRING_HERE##') {
> - return open_pipe_activestate(@_);
> - } else {
> - return open_pipe_normal(@_);
> - }
> -}
> -
> -sub open_pipe_activestate {
> - tie *fh, "Git::ActiveStatePipe", @_;
> - return *fh;
> -}
> -
> -sub open_pipe_normal {
> - my (@execlist) = @_;
> -
> - my $pid = open my $kid, "-|";
> - defined $pid or die "Cannot fork: $!";
> -
> - unless ($pid) {
> - exec @execlist;
> - die "Cannot exec @execlist: $!";
> - }
> -
> - return $kid;
> -}
I don't see that Git.pm provides the compatibility functionality we have
stubbed out, here.
(It clearly has never been used, because there hasn't been a patch to
set the actual ActiveState string there.. 'MSWin32', btw.)
I suspect that the other scripts, that have more users, will see
regression complaints when the qx() calls get replaced by calls to
open(my $fh, "-|"), indirectly, in Git.pm
--
Ryan Anderson
sometimes Pug Majere
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html