Yakov Lerner <iler.ml@xxxxxxxxx> writes: > Before this patch, -DDEFAULT_GIT_TEMPLATE_DIR was passed on compilation > command line to all and every %c compiled. In fact the macro > is used by only one .c file, and unused by all other .c files. > Remove -DDEFAULT_GIT_TEMPLATE_DIR where unused. Follow the examlpe of > exec_cmd.o. Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used. Thanks. By the way, I really started hating that we have $(GIT_VERSION) in $(TRACK_CFLAGS). Since the version string is tied to the HEAD commit object name, having it in $(TRACK_CFLAGS) means that every time I switch branches, make a new commit on top of the current branch, or checkout-compile-and-then-make-local-change sequence would force pretty much everything to be rebuilt. Do you think of any downside if I remove it from the list of symbols in TRACK_CFLAGS? For that matter, I do not think tracking prefix_SQ makes much sense since what matters are bindir, gitexecdir and template_dir which are already covered, and prefix is merely a convenience to set these three (four, counting GIT_PYTHON_DIR; we probably should add it to TRACK_CFLAGS). Thoughts? - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html