Re: [PATCH] Check and document the options to prevent mistakes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes:

> +# Verify the user input
> +
> +foreach my $entry (@to) {
> +	die "Comma in --to entry: $entry'\n" unless $entry !~ m/,/;
> +}
> +

Perhaps, avoiding double negation would be easier on the eyes.

        die ... if $entry =~ /,/

Does it grok '"Biederman, Eric W." <eb@xxxxxx>' some people seem
to do properly, or do we care (I personally don't)?



-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]