On Tuesday June 20th 2006 Nguy???n Thái Ng???c Duy wrote: > While inspecting patch-delta.c, I encounter this: > if (cp_off + cp_size < cp_size || > cp_off + cp_size > src_size || > cp_size > size) > goto bad; > "cp_off + cp_size < cp_size" doesn't make sense to me. Is it on purpose? It protects against possible overflow. Adding fixed length integers is "wraparound" after all and discards the "carry" bit. -- Marco Roeland - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html