Re: [PATCH] fix git alias

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 14 Jun 2006, Junio C Hamano wrote:

>  * This would make "git l -n 4" work when you have "alias.l =
>    log -M" in your configuration.  The original code generated
>    an equivalent of "git log -M l -n 4".

Of course, I tested it only with links... (ln git git-l). Thanks.

>    There is another more grave problem I seem to be hitting but
>    haven't figured out (and will probably not figure out while
>    away); I'd appreciate if you can track it down.  With
>    "alias.wh = whatchanged --patch-with-stat", "git wh HEAD --
>    mailinfo.c" segfaults at fclose() in git_config_from_file()
>    when it reads the configuration for the second time (the
>    first time being getting the alias).  The second call comes
>    via init_revisions() calling setup_git_directory().  Oddly
>    I do not seem to be able to reproduce this segfault on amd64.

I will do that.

Note that I have a mmap()ed version in the pipeline. I just wanted to wait 
with that until I manage to implement your cool idea about config 
rewriting. Obviously, this mmap()ed version does not have this problem.

Ciao,
Dscho

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]