git-applymbox broken?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It looks like something has broken git-applymbox lately.

The "From: authorname" lines are no longer removed from the message, and 
are duplicated in the commit log. This has resulted in several recent 
kernel commits looking like this:

	commit c0bbbc73d58f1b774cd987b5687a478a027f137c
	Author: Christoph Lameter <clameter@xxxxxxx>
	Date:   Sun Jun 11 15:22:26 2006 -0700
	
	    [PATCH] typo in vmscan.c
	    
	    From: Christoph Lameter <clameter@xxxxxxx>
	    
	    Looks like a comma was left from the conversion from a struct to an
	    assignment.
	    
	    Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
	    Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
	    Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>

where that "From:" in the body is totally wrong. I just didn't notice, 
until now. Arrr!

I _suspect_ that this is the work by Eric Biederman, ie part of the 
patches that do "Allow in body headers beyond the in body header 
prefix." and "Refactor commit messge handling."

Eric? Can you please fix this up? Lines from the body of the email that 
have been used to set authorship should _not_ also show up in the commit 
message.

		Linus
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]