Re: http-fetch segfault fix?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2006-06-06 at 22:58 -0700, Junio C Hamano wrote:
> Pavel Roskin <proski@xxxxxxx> writes:
> 
> > The Valgrind diagnostics confirms that obj_req->slot is not initialized
> > (as opposed to being a pointer to a freed area or something else):
> >
> > ==27182== Conditional jump or move depends on uninitialised value(s)
> > ==27182==    at 0x4070EA: abort_object_request (http-fetch.c:1059)
> > ==27182==    by 0x4071CE: fetch_object (http-fetch.c:1078)
> > ==27182==    by 0x4073EC: fetch (http-fetch.c:1126)
> > ==27182==    by 0x403125: loop (fetch.c:180)
> > ==27182==    by 0x403369: pull (fetch.c:248)
> > ==27182==    by 0x407A13: main (http-fetch.c:1271)
> >
> > Line 1059 is:
> > if (obj_req->slot) {
> 
> Thanks.  That is indeed a very good sign.

Both git-clone instances (with and without USE_CURL_MULTI) have
completed successfully on http://www.denx.de/git/linux-2.6-denx.git

Nick, thank you for fixing this bug!

-- 
Regards,
Pavel Roskin

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]