Jon Loeliger <jdl@xxxxxxx> writes: > Add client side sending of "\0host=%s\0" extended > arg for git native protocol, backwards compatibly. > > Signed-off-by: Jon Loeliger <jdl@xxxxxxx> > --- > connect.c | 42 ++++++++++++++++++++++++++++++++---------- > 1 files changed, 32 insertions(+), 10 deletions(-) > > I've tested this against an "old" daemon, and my new daemon > running on jdl.com that understands the new host=%s parameter. > Both appear to work still. Thanks. > However, I don't have a setup to test a proxy connection, > and I left FIXME: down there asking the question if it is > even needed in this case as well. I _think_ so, but I am > just not sure. (It should be a straight pass-through to > another git: native protocol, right?) I think so. > And if it is needed there too, do you want to refactor > these two packet_writes() for commonality again? Let me munge that part and push it out. I've tested it lightly both with and without proxy. My proxy was a single liner shell script: nc -o /var/tmp/nc.log localhost 9418 whose dump started with this nice request packet: > 00000000 30 30 35 62 67 69 74 2d 75 70 6c 6f 61 64 2d 70 # 005bgit-upload-p > 00000010 61 63 6b 20 2f 6f 70 74 2f 70 61 63 6b 72 61 74 # ack /opt/packrat > 00000020 2f 70 6c 61 79 70 65 6e 2f 70 75 62 6c 69 63 2f # /playpen/public/ > 00000030 69 6e 2d 70 6c 61 63 65 2f 67 69 74 2f 67 69 74 # in-place/git/git > 00000040 2e 6a 75 6e 69 6f 00 68 6f 73 74 3d 6c 6f 63 61 # .junio.host=loca > 00000050 6c 68 6f 73 74 3a 34 34 33 33 00 # lhost:4433. for a request "peek-remote git://localhost:4433/opt/.../git.junio". I suspect that a real git proxy, if somebody ever writes one, would read the first outgoing packet reads the request (including this host= stuff) and connect to the true destination intelligently after sending out a modified request packet. Takers? - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html