Hi, On Mon, 5 Jun 2006, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Hi, > > > > On Mon, 5 Jun 2006, Junio C Hamano wrote: > > > >> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > >> > >> > When calling git_setup_directory_gently, and GIT_DIR was set, it just > >> > ignored the variable nongit_ok. > >> > >> Hmph. Is this really a breakage? That is, gently() is meant > >> for a case where you do not know if you even find a git > >> repository and tell it not to complain because you are prepared > >> for the case where you are not in a git repository. > > > > Yes, it is a breakage: in git-clone, line 212, we explicitely set GIT_DIR > > (to the not-yet-existing repository path), and call git-init-db. Now, with > > the alias thing we need to get the config if it exists, so we _got_ to > > call gently(). Boom. > > Hmph. Would it be a bug in clone that does not create GIT_DIR > then? I don't think so. The whole point in calling git-init-db is to create that. GIT_DIR is set so that the otherwise nice work-in-a-subdirectory does not kick in. Imagine for example: git-clone ./. victim (taken straight out of t5400). If GIT_DIR was not set, git-init-db (which reads repositoryformat from the config if that exists, right?) would find .git/ in git/t/trash, and _not_ create git/t/trash/victim/.git/. Ciao, Dscho - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html