Hi,
On Wed, 31 May 2006, Junio C Hamano wrote:
> This resurrects --signoff option to format-patch.
Sorry; I was in cinema, so I missed all the action.
> + const char *committer = git_committer_info(1);
> + const char *endpos = strchr(committer, '>');
> + if (!endpos)
> + die("bogos committer info %s\n", committer);
> + add_signoff = xmalloc(endpos - committer + 2);
> + memcpy(add_signoff, committer, endpos - committer + 1);
> + add_signoff[endpos - committer + 1] = 0;
> + }
I don't know, but it may be a good idea to make this more general: Why not
build the sign-off line here, so that you could also add more than one
sign-off lines ('--signoff="The great committer <ter@xxxxxxx>"'), and
maybe even Acked-by's?
> + /* First see if we already have the sign-off by the signer */
> + while (1) {
> + cp = strstr(cp, signed_off_by);
> + if (!cp)
> + break;
> + cp += strlen(signed_off_by);
> + if ((cp + signoff_len < buf + at) &&
> + !strncmp(cp, signoff, signoff_len) &&
> + isspace(cp[signoff_len]))
> + return at; /* we already have him */
> + }
Okay, this would be a little harder with multiple sign-offs. But the check
could be easier, i.e. if we say
rev.add_signoff = xmalloc(enough_room);
strcpy(rev.add_signoff, "\nSigned-off-by: ");
strcat(rev.add_signoff, committer_ident);
strcat(rev.add_signoff, "\n");
then a simple
p = strstr(commit_buffer, rev.add_signoff);
if (p)
return (int)(p - commit_buffer);
would do the trick.
And shouldn't we error out if there is not enough room for a sign-off?
Sorry for all the nit-picking.
Ciao,
Dscho
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html