Jeff King <peff@xxxxxxxx> writes: > On Tue, May 23, 2006 at 01:47:01PM -0400, Morten Welinder wrote: > >> Why run "env" and not just muck with %ENV? >> >+ my $pid = open2(my $commit_read, my $commit_write, >> >+ 'env', >> >+ "GIT_AUTHOR_NAME=$author_name", >> >+ "GIT_AUTHOR_EMAIL=$author_email", >> >+ "GIT_AUTHOR_DATE=$commit_date", >> >+ "GIT_COMMITTER_NAME=$author_name", >> >+ "GIT_COMMITTER_EMAIL=$author_email", >> >+ "GIT_COMMITTER_DATE=$commit_date", >> >+ 'git-commit-tree', $tree, @commit_args); > > Oops, that's an obvious fork optimization that I should have caught. Are you two talking about running git-commit-tree via env is two fork-execs instead of just one? Does that have a measurable difference? Not that I have anything against the updated code, but I do not particularly thing it is such a big issue. > PS What is the preferred format for throwing patches into replies like > this? Putting the patch at the end (as here) or throwing the reply > comments in the ignored section near the diffstat? You could do it either way. Although I personally find the former easier to read (meshes well with "do not top post" mantra), it appears many other people finds the cover letter material should come after the first '---' separator. If you append the patch to your message, btw, you would need to realize that the receiving end needs to edit your message to remove the top part before running "git am" to apply. - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html