commit() does not need to be an anonymous subreference. Keep it simple. Signed-off-by: Martin Langhoff <martin@xxxxxxxxxxxxxxx> --- git-cvsimport.perl | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) a0bbc1c2010ca46fc215453d5e4c4853c679f950 diff --git a/git-cvsimport.perl b/git-cvsimport.perl index c1923d1..2ecfe14 100755 --- a/git-cvsimport.perl +++ b/git-cvsimport.perl @@ -563,7 +563,7 @@ my $state = 0; my($patchset,$date,$author_name,$author_email,$branch,$ancestor,$tag,$logmsg); my(@old,@new,@skipped); -my $commit = sub { +sub commit { my $pid; while(@old) { my @o2; @@ -853,7 +853,7 @@ # VERSION:1.96->1.96.2.1 if ($opt_L && $commitcount++ >= $opt_L) { last; } - &$commit(); + commit(); $state = 1; } elsif($state == 11 and /^-+$/) { $state = 1; @@ -863,7 +863,7 @@ # VERSION:1.96->1.96.2.1 print "* UNKNOWN LINE * $_\n"; } } -&$commit() if $branch and $state != 11; +commit() if $branch and $state != 11; unlink($git_index); -- 1.3.2.g82000 - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html