Jim Meyering wrote: > In a very shallow audit, I spotted code where overflow was not detected. > But it's hardly critical. > > Currently, > > git-diff HEAD HEAD > > is equivalent to this > > git-diff HEAD HEAD~18446744073709551616 # aka 2^64 > > Exercising git-rev-parse directly, currently I get this: > > $ git-rev-parse --no-flags --sq HEAD~18446744073709551616 > '639ca5497279607665847f2e3a11064441a8f2a6' > > It'd be better to produce a diagnostic and fail: > > $ ./git-rev-parse --no-flags --sq -- HEAD~18446744073709551616 /dev/null > fatal: ambiguous argument 'HEAD~18446744073709551616': unknown revision or filename Wouldn't it remove ability to say "to the root commit"? One can do it now I guess exactly by specyfying overly large N. Although there should probably be some limit... or not. -- Jakub Narebski Warsaw, Poland - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html