Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > On Sat, 20 May 2006, Junio C Hamano wrote: > >> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > There are two options missing: --signoff and --check. > > --signoff is my fault: it is probably a good thing to drop it from > format-patch, and only leave it in applymbox. I think that is fine. format-patch only formats existing commits, and if you are signing off something you could already have done that when you made the commits anyway, so that flag was redundant. > As for --check: how about having yet another diff "format": > DIFF_FORMAT_CHECK? Instead of showing the diff, it only shows the line(s) > which are offending. Never thought of that but I think it makes sense. I liked the way Sean did the --summary; I am wondering if we could clean up the --with-* stuff in a similar way. We currently do "if DIFF_FORMAT_XYZ or with_xyz then do this" which is quite honestly disgusting (my fault). - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html