On Thu, May 18, 2006 at 04:48:26AM -0600, Eric W. Biederman wrote: > Junio C Hamano <junkio@xxxxxxx> writes: > > > ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes: > > > >> Junio C Hamano <junkio@xxxxxxx> writes: > >> > >>> What's the expected workflow for you to work on a 1300 patch > >>> series you get from Andrew in the next installment to deal with > >>> 88 unattributed patches? Answer the question 88 times and make > >>> sure you get the answers right every time? Or abort and > >>> hand-edit them to help mailinfo to notice the correct > >>> attribution and re-run? > >> > >> For the internal consumption case it isn't a big deal. I > >> can specify --author with something bogus and it works. > > > > Yes. > > > >>> I know I am guilty of suggesting "going interactive", but I have > >>> a feeling that having an optional file that maps patch-name to > >>> author might be easier to work with. If the old patches are > >>> recycled in the updated -mm set, you probably can reuse the > >>> mapping for them, adding entries for newly introduced "unnamed" > >>> patches as needed. > >> > >> Short of getting the script where it has a sane restart in the > >> middle mode going interactive and asking questions makes a lot > >> of sense. Especially with smaller trees. > > > > Yes perhaps on smaller trees, but that does not mean much. For > > smaller trees and/or smaller patch series almost anything would > > do. > > Yes, a smaller patch series, that is what I meant. > Most quilt trees that I know about are in needed small. $ quilt series | wc -l 207 And that is about "normal" for me. Sometimes it grows to about 500+ patches, but that only happens when there's a longer kernel release cycle. Another tree that I work on all the time is about 700+ patches, and yet another 2000+. So you might re-evaluate your statement about "small" quilt series :) In looking at your script, it doesn't seem to be able to handle patches in quilt that are in mbox format. Any thoughts to allow this to handle the attribution properly? Right now my development flow has me converting my quilt tree to one big mbox file and then using 'git applymbox' to import it before asking Linus to pull from it. With your script I could skip at least one step, which would save me some time... thanks, greg k-h - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html