On Thu, 18 May 2006 19:47:19 -0700 Junio C Hamano <junkio@xxxxxxx> wrote: > If that (specifically, "when passed to git log") is what you > want, do all of that in "git log" please. I haven't checked, > but I suspect your changes would break git-rev-list and makes it > disobey the options the user gives it. > Well, it's more general than just git log, but that's primarily where one would see it. Essentially the patch is saying that specifying both a "revs->diffopt.pickaxe" string and "revs->always_show_header" is illegal and proceeds to use pickaxe instead of the other. Is there any place that depends on the ability to specify both a pickaxe string _and_ always_show_header? If not, it's hard to see how this patch could break anything. Sean - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html